From owner-ports-jp@jp.freebsd.org  Tue Jul 29 00:09:13 1997
Received: by jaz.jp.freebsd.org (8.8.6+2.7Wbeta5/8.7.3) id AAA00168
	Tue, 29 Jul 1997 00:09:13 +0900 (JST)
Received: by jaz.jp.freebsd.org (8.8.6+2.7Wbeta5/8.7.3) with ESMTP id AAA00163
	for <ports-jp@jp.freebsd.org>; Tue, 29 Jul 1997 00:09:12 +0900 (JST)
Received: from cylon.on.rim.or.jp (ppp099.on.rim.or.jp [202.247.138.227]) by april.on.rim.or.jp (8.8.5/3.4Wbeta6-rim1.1) with ESMTP id AAA20410; Tue, 29 Jul 1997 00:06:04 +0900 (JST)
Message-Id: <199707281506.AAA20410@april.on.rim.or.jp>
Received: from localhost by cylon.on.rim.or.jp (8.8.5/3.5Wpl5-97062421)
	id AAA01161; Tue, 29 Jul 1997 00:04:46 +0900 (JST)
To: ports-jp@jp.freebsd.org
Cc: itojun@itojun.org
From: Yoshishige Arai <ryo2@on.rim.or.jp>
In-Reply-To: Your message of "Mon, 28 Jul 1997 11:30:16 +0900"
References: <14241.870057016@itojun.csl.sony.co.jp>
X-Mailer: Mew version 1.70 on Emacs 19.28.1 / Mule 2.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Date: Tue, 29 Jul 1997 00:04:45 +0900
Reply-To: ryo2@on.rim.or.jp
Precedence: bulk
X-Distribute: distribute [version 2.1 (Alpha) patchlevel=20]
X-Sequence: ports-jp 1466
Subject: [ports-jp 1466] Re: portlint 1.40
Errors-To: owner-ports-jp@jp.freebsd.org
Sender: owner-ports-jp@jp.freebsd.org

$B9S0f!w%j%`%M%C%H$G$9!#(B

On Mon, 28 Jul 1997 11:30:16 +0900 ([ports-jp 1464] portlint 1.40)
itojun@itojun.org wrote:

> 	$B$R$5$S$5$K(Bportlint$B$r2~B$$7$^$7$?!#(Br1.40$B$G$9!#(B
> 	ftp://ftp.foretune.co.jp/pub/tools/portlint/
> 
> 	$B$J$s$+D6J#;($K$J$C$F$-$F$d$C$F$i$l$^$X$s!#(B

$B$&$&$%!"$46lO+$5$^$G$9!#(B
portlint$B%Q%C%1!<%8%5%$%:$b=gD4$KBg$-$/$J$C$F$$$k$h$&$G(B(^^;
$B$=$m$C$H7y$K$J$C$FMh$?:"$+$H$*;!$7$^$9$,(B... $BFs!";0IT6q9g$NJs9p$r!#(B

% portlint.pl /usr/ports/foo/bar
$B$N$h$&$K%G%#%l%/%H%j;XDj$G;H$&$H!"(Bpatch-?? $B$,A4It!"(B

OK: checking /usr/ports/x11/fvwm95/patches/patch-aa.
FATAL: no /usr/ports/x11/fvwm95/patches/patch-aa in "/usr/ports/x11/fvwm95".
OK: checking /usr/ports/x11/fvwm95/patches/patch-ab.
FATAL: no /usr/ports/x11/fvwm95/patches/patch-ab in "/usr/ports/x11/fvwm95".
   :

$B$N$h$&$K=3$i$l$^$9!#(B
$B$=$l$H!"(B

.if defined(USE_APM)
        @${ECHO} "===>  Adding an \"APM\" patch for ${PKGNAME}"
	@${CP} ${FILESDIR}/${EXTRA_PATCH} ${PATCHDIR}
.endif
$B$_$?$$$J$H$3$m$,$"$k$H!"(B
WARN: possible direct use of command "patch" found. use ${PATCH} instead.
$B$,=P$^$9!#(B
$B$b0l$D!"(B
MASTER_SITES+=   ftp://ftp.freebsd.org/pub/FreeBSD/distfiles/
$B$J$s$F$N$,$"$k$H!"(B
WARN: possible direct use of "distfiles" found in Makefile. if so, use ${DISTDIR} instead.
WARN: possible direct use of "files" found in Makefile. if so, use ${FILESDIR} instead.
$B$H!"%@%V%k$G0z$C$+$+$C$F$7$^$$$^$9!#(B

$B>e5-;0E@$K4X$9$k=$@5%Q%C%A$rF~$l$F$*$-$^$9!#(B
$B0lE@L\$O!"(B%checker$B$K2C$($k$H$-!"(B$checer{'patches/patch-aa'}$B$N$h$&$J%O%C(B
$B%7%e$K$7!"(B
$BFsE@L\$K4X$7$F$O!"%3%^%s%I%A%'%C%/;~$K(B \", \' $B$r:o$C$F$+$i!"(B"",''$BFb$N(B
$BJ8;z$r%9%-%C%W$9$k$h$&$K$7$F(B .*_SITES= $B9T$r%A%'%C%/$+$i30$9$3$H$GBP=h!"(B
$B;0E@L\$OC18l6h@Z$jDI2C$G:Q$_$^$7$?!#(B
$B0J2<E,Ev$K$_$D$/$m$C$F;H$C$F2<$5$$!#(B

====================================================
--- portlint.pl.orig	Mon Jul 28 11:28:06 1997
+++ portlint.pl	Mon Jul 28 23:09:12 1997
@@ -91,10 +91,11 @@
 	}
 }
 foreach $i (<$portdir/patches/patch-??>) {
+	($pname) = ($i =~ /(patches\/[^\/]+)$/);
 	next if (! -T $i);
-	next if (defined $checker{$i});
-	push(@checker, $i);
-	$checker{$i} = 'checkpatch';
+	next if (defined $checker{$pname});
+	push(@checker, $pname);
+	$checker{$pname} = 'checkpatch';
 }
 foreach $i (@checker) {
 	print "OK: checking $i.\n";
@@ -103,7 +104,7 @@
 	} else {
 		$proc = $checker{$i};
 		&$proc($i) || &perror("Cannot open the file $i\n");
-		if ($i !~ /\/patches\//) {
+		if ($i !~ /patches\//) {
 			&checklastline($i)
 				|| &perror("Cannot open the file $i\n");
 		}
@@ -407,8 +408,13 @@
 	}
 	$cmdnames{'gunzip'} = '${GUNZIP_CMD}';
 	$cmdnames{'gzip'} = '${GZIP_CMD}';
+	$cmdpart = $whole;
+	$cmdpart =~ s/\\\n//g; $cmdpart =~ s/\\["']//g;
+	$cmdpart =~ s/\n[A-Z0-9-_]+SITES[?:+]?=[^\n]+\n/\n/;
+	$cmdpart =~ s/"([^"]+)"/""/g;
+	$cmdpart =~ s/'([^']+)'/''/g;
 	foreach $i (keys %cmdnames) {
-		if ($whole =~ /[ \t\/]$i[ \t\n]/) {
+		if ($cmdpart =~ /[ \t\/]$i[ \t\n]/) {
 			&perror("WARN: possible direct use of command \"$i\" ".
 				"found. use $cmdnames{$i} instead.");
 		}
@@ -907,7 +913,7 @@
 work		\${WRKDIR} instead
 EOF
 	foreach $i (keys %cmdnames) {
-		if ($str =~ /(\.\/|\$[\{\(]\.CURDIR[\}\)]\/)?($i)\//) {
+		if ($str =~ /(\.\/|\$[\{\(]\.CURDIR[\}\)]\/)?(\b$i)\//) {
 			&perror("WARN: possible direct use of \"$i\" ".
 				"found in $file. if so, use $cmdnames{$i}.");
 		}
====================================================
 --------
 $B9S0fNI=E(B(Yoshishige Arai)
 ryo2@on.rim.or.jp
